Update visible-selector.xml #522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue jquery#409.
| @@ -11,6 +11,7 @@ | |||
| <p>Elements with <code>visibility: hidden</code> or <code>opacity: 0</code> are considered visible, since they still consume space in the layout.</p> | |||
| <p>Elements that are not in a document are considered to be hidden; jQuery does not have a way to know if they will be visible when appended to a document since it depends on the applicable styles.</p> | |||
| <p>During animations that hide an element, the element is considered to be visible until the end of the animation. During animations to show an element, the element is considered to be visible at the start at the animation.</p> | |||
| <p>Attempting to detect if an <code>option</code> element is visible or not is completely useless. It'll be always hidden, regardless if it's selected (thus visible) or not.</p> | |||
There was a problem hiding this comment.
@AurelioDeRosa . This is good information to have in here. Thanks! I'm just not sure about the phrasing (e.g. "is completely useless" and "It'll be always"). Mind if I merge it in with some editing? Authorship will still go to you, of course.
There was a problem hiding this comment.
@kswedberg. Hi! Feel free to change anything you want to further improve the documentation. I also don't mind about the authorship as long as we, together, can improve the project. :)
|
@kswedberg Is this PR good to merge? |
|
Thanks for the ping, @AurelioDeRosa . I'll check it out tonight. |
|
Thank you for merging @kswedberg. I think there are other PRs ready to be merged, but I don't want to bother you pinging on each of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #409.